Change in osmo-ttcn3-hacks[master]: bsc: Drop mp_enable_osmux_test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 22 10:57:28 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24968 )

Change subject: bsc: Drop mp_enable_osmux_test
......................................................................

bsc: Drop mp_enable_osmux_test

This module parameter is not needed anymore, since latest already
supports this feature for a while.

Change-Id: I3a2a4f984443a40285440a7fc54b1797a943e4b0
---
M bsc/BSC_Tests.ttcn
1 file changed, 2 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 2b11dc9..ae805e3 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -680,11 +680,6 @@
 	};
 	boolean mp_enable_lcs_tests := true;
 
-	/* Whether to enable osmux tests. Can be dropped completely and enable
-	   unconditionally once new version of osmo-bsc is released (current
-	   version: 1.4.1) */
-	boolean mp_enable_osmux_test := true;
-
 	/* Whether to enable dyn TS SDCCH8 tests. Can be dropped completely and enable
 	   unconditionally once new version of osmo-bsc is released (current
 	   version: 1.7.0) */
@@ -1121,9 +1116,7 @@
 	activate(as_Tguard());
 
 	f_init_vty("VirtMSC");
-	if (mp_enable_osmux_test) {
-		f_vty_allow_osmux(allow_osmux);
-	}
+	f_vty_allow_osmux(allow_osmux);
 
 	var my_BooleanList allow_attach := { false, false, false };
 	f_init_statsd("VirtMSC", vc_STATSD, mp_test_ip, mp_bsc_statsd_port);
@@ -9415,9 +9408,7 @@
 	execute( TC_assignment_codec_req_hr_fr() );
 	execute( TC_assignment_codec_req_fr_hr() );
 
-	if (mp_enable_osmux_test) {
-		execute( TC_assignment_osmux() );
-	}
+	execute( TC_assignment_osmux() );
 
 	/* RLL Establish Indication on inactive DCHAN / SAPI */
 	execute( TC_rll_est_ind_inact_lchan() );

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24968
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3a2a4f984443a40285440a7fc54b1797a943e4b0
Gerrit-Change-Number: 24968
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210722/75bb956b/attachment.htm>


More information about the gerrit-log mailing list