This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24950 ) Change subject: _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it ...................................................................... _select_sdcch_for_call: Avoid 2nd lchan lookup when finally selecting it We already looked it up, it's not necessary to look it up again by calling lchan_select_by_type(). Let's instead call lchan_select_set_type() directly on the lchan pointer. Related: SYS#5309 Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 9b6429d..c84aeda 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1964,8 +1964,7 @@ } select_lchan: - /* FIXME: we already have lchan, simply do lchan->type = GSM_LCHAN_SDCCH? Split lchan_select_by_type in 2 functions? */ - lchan = lchan_select_by_type(bts, GSM_LCHAN_SDCCH); + lchan_select_set_type(lchan, GSM_LCHAN_SDCCH); return lchan; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1054c18f58c9e249f263e3e97a365a1fd8b03a93 Gerrit-Change-Number: 24950 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210720/1863f860/attachment.htm>