Change in osmo-mgw[master]: mgcp_ratectr: add stats items to monitor trunk usage

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

pespin gerrit-no-reply at
Mon Jul 19 10:51:53 UTC 2021

pespin has posted comments on this change. ( )

Change subject: mgcp_ratectr: add stats items to monitor trunk usage

Patch Set 5:

File src/libosmo-mgcp/mgcp_endp.c: 
PS4, Line 138: 	if (endp->trunk->stats.common) {
> There is a problem with the unit-tests. […]
Then I'd fix the unit tests to do proper stuff instead of adding specific code paths for unit tests like here. 
File src/libosmo-mgcp/mgcp_ratectr.c: 
PS4, Line 285: 	snprintf(stat_name, sizeof(stat_name), "%s-%d:common", mgcp_trunk_type_strs_str(trunk->trunk_type),
> I also don't understand why, I should check this back and refactor it too (if possible) - but it wou […]
sure no problem, I was just asking to make sure it was not already a unsigned int. Even if it's an int it may make more sense to put it as a %u in case at a later stage you move it to be unsigned, so that you then don't forget to change %d->%u here.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib7b654168dc3512f55e45cc4755dc1f6f423d023
Gerrit-Change-Number: 24942
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at>
Gerrit-Comment-Date: Mon, 19 Jul 2021 10:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at>
Comment-In-Reply-To: dexter <pmaier at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list