Change in osmo-msc[master]: sgs_iface.c: Improve logging when paging over SGs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

pespin gerrit-no-reply at
Mon Jul 12 15:44:08 UTC 2021

pespin has submitted this change. ( )

Change subject: sgs_iface.c: Improve logging when paging over SGs

sgs_iface.c: Improve logging when paging over SGs

Change-Id: I745d3e904583ddf170ec1a1ceac5a49b72e813e3
M src/libmsc/sgs_iface.c
1 file changed, 3 insertions(+), 3 deletions(-)

  pespin: Looks good to me, approved
  Jenkins Builder: Verified

diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index 9d7b6fc..1dfbace 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -476,9 +476,6 @@
 	struct gsm29118_paging_req paging_params;
 	struct sgs_mme_ctx *mme;
-	LOGP(DMSC, LOGL_NOTICE, "XXXXXXXXXX state == %d  conf_by_radio_contact_ind == %d\n",
-	     vsub->sgs_fsm->state, vsub->conf_by_radio_contact_ind);
 	/* See also: 3GPP TS 29.118, chapter Paging Initiation */
 	if (vsub->sgs_fsm->state == SGS_UE_ST_NULL && vsub->conf_by_radio_contact_ind == true) {
 		LOGPFSMSL(vsub->sgs_fsm, DPAG, LOGL_ERROR, "Will not Page (conf_by_radio_contact_ind == true)\n");
@@ -496,6 +493,9 @@
 	if (vlr_sgs_pag_pend(vsub))
 		return 0;
+	LOGMME(mme, LOGL_INFO, "Paging on SGs: %s for %s (conf_by_radio_contact_ind=%d)\n",
+	       vlr_subscr_name(vsub), sgsap_service_ind_name(serv_ind), vsub->conf_by_radio_contact_ind);
 	memset(&paging_params, 0, sizeof(paging_params));
 	osmo_strlcpy(paging_params.imsi, vsub->imsi, sizeof(paging_params.imsi));
 	osmo_strlcpy(paging_params.vlr_name, mme->sgs->cfg.vlr_name, sizeof(paging_params.vlr_name));

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I745d3e904583ddf170ec1a1ceac5a49b72e813e3
Gerrit-Change-Number: 24915
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list