Change in libosmocore[master]: gprs_ns2_vc_fsm: rename state UNCONFIGURED -> DISABLED

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

lynxis lazus gerrit-no-reply at
Fri Jul 9 15:09:40 UTC 2021

lynxis lazus has posted comments on this change. ( )

Change subject: gprs_ns2_vc_fsm: rename state UNCONFIGURED -> DISABLED

Patch Set 2:

> Patch Set 2:
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > I'm not sure/convinced that 'unconfigured' is a wrong name.  Why would "unconfigured" only happen at start-up?  What event is causing it to become unconfigured later on again, and why is the name wrong? Is it still in some way "configured" while in that state?
> > 
> > Original the unconfigured was just the initial state. Later a vty command for testing was introduced. And now the frame relay is forcing all NSVC into the unconfigured state when the DLCI become unavailable.
> A bit more bike shedding, but to me "disabled" sounds like some active intervention is needed before the NSVC can be used again. "Unconfigured" as a state name sounds fine to me, or maybe something like "initial", "inactive"

Maybe standby?

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f46ce5e27d7556d5e17bc236f1765d42aecbe0c
Gerrit-Change-Number: 24685
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at>
Gerrit-Reviewer: dexter <pmaier at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-CC: laforge <laforge at>
Gerrit-Comment-Date: Fri, 09 Jul 2021 15:09:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list