Change in osmo-bsc[master]: RES IND: pick lchan with least interference

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24885 )

Change subject: RES IND: pick lchan with least interference
......................................................................


Patch Set 2:

(5 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24885/1/src/osmo-bsc/lchan_select.c 
File src/osmo-bsc/lchan_select.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24885/1/src/osmo-bsc/lchan_select.c@55 
PS1, Line 55: 	if (log) \
> This change looks not related.
i want to use the log statement without { } braces ...


https://gerrit.osmocom.org/c/osmo-bsc/+/24885/1/src/osmo-bsc/lchan_select.c@107 
PS1, Line 107: 				if (found_lchan != was)
... here.


https://gerrit.osmocom.org/c/osmo-bsc/+/24885/1/src/osmo-bsc/lchan_select.c@113 
PS1, Line 113: 				else
and here


https://gerrit.osmocom.org/c/osmo-bsc/+/24885/1/src/osmo-bsc/lchan_select.c@126 
PS1, Line 126: 	if (found_lchan)
and here


https://gerrit.osmocom.org/c/osmo-bsc/+/24885/1/src/osmo-bsc/lchan_select.c@131 
PS1, Line 131: 	else
and here



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24885
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I844494092193811dfd9fa4d52983cbaed0fc9248
Gerrit-Change-Number: 24885
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jul 2021 18:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210708/74d0ded7/attachment.htm>