Change in osmo-bsc[master]: vty 'interference-meas level-bounds': explain duality in ordering

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24888 )


Change subject: vty 'interference-meas level-bounds': explain duality in ordering
......................................................................

vty 'interference-meas level-bounds': explain duality in ordering

Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/24888/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index e0aa97f..7985826 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -5008,7 +5008,9 @@
 	      "interference-meas level-bounds "
 		"<-120-0> <-120-0> <-120-0> <-120-0> <-120-0> <-120-0>",
 	      "Interference measurement parameters\n"
-	      "Interference level Boundaries\n"
+	      "Interference level Boundaries. 3GPP do not specify whether these should be in ascending or descending"
+	      " order (3GPP TS 48.058 9.3.21 / 3GPP TS 52.021 9.4.25). OsmoBSC supports either ordering, but possibly"
+	      " some BTS models only return meaningful interference levels with one specific ordering.\n"
 	      "Interference boundary 0 (dBm)\n"
 	      "Interference boundary X1 (dBm)\n"
 	      "Interference boundary X2 (dBm)\n"
@@ -5021,7 +5023,6 @@
 
 	for (i = 0; i < ARRAY_SIZE(bts->interf_meas_params_cfg.bounds_dbm); i++) {
 		bts->interf_meas_params_cfg.bounds_dbm[i] = abs(atoi(argv[i]));
-		/* TODO: ensure ascending (or descending?) order */
 	}
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If71e20e95d29e7f03739ee04e1ef429bf8bd51ed
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210708/c645246d/attachment.htm>