This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24823 ) Change subject: mgcp_protocol: add support for wildcarded DLCX ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2//COMMIT_MSG@9 PS2, Line 9: At the moment osmo-mgw does not support wildcarded DLCX requests that > I was surprised about this too. […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c@1350 PS2, Line 1350: return create_ok_response(endp, 200, "DLCX", p->trans); > So if the request does not refer to a specific endpoint, which endpoint is selected and passed as "e […] Its a random free endpoint. This is a design problem osmo-mgw is suffering from. We would have to add a trunk member to struct mgcp_parse_data that is at least populated with a trunk and if the request is wildcarded we would use this p->trunk member only and not picking the trunk from the p->endp->trunk member. We might consider fixing this in a separate patch and put that patch before this one - what do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0770cf46d93ab09efe9cafdd56d2e3f1132db189 Gerrit-Change-Number: 24823 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jul 2021 13:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210707/f8680ec7/attachment.htm>