Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

neels gerrit-no-reply at
Mon Jul 5 21:42:37 UTC 2021

neels has posted comments on this change. ( )

Change subject: handover_ctrl: add control interface for handover settings

Patch Set 6:

File include/osmocom/bsc/handover_cfg.h: 
PS6, Line 264: 		"handover2 min-free-slots tch-h\0") \
you should not need to include '\0' because a terminating nul is present in every string constant 
File src/osmo-bsc/handover_ctrl.c: 
PS6, Line 32: /* Verify a VTY command argument against its value specification, the value
Here we could add:

 In handover_cfg.h the config items are described in VTY syntax. To be able to use those here
 in the CTRL interface, we parse the config arguments like the VTY would. 
Hm, I don't understand how this works.

so CTRL_CMD is mostly "", so the name becomes like

  "" "handover 2 " "power budget hysteresis"
  = "handover 2 power budget hysteresis"

But how about "handover2 min-free-slots tch-f"?
IIUC this should become

  "handover2 min-free-slots tch-f" "handover2 " "min-free-slots tch/f"
  = "handover2 min-free-slots tch-fhandover2 min-free-slots tch/f" 
PS6, Line 114: 		cmd->reply = talloc_asprintf(cmd, "%s", #DEFAULT_VAL); \
(we would usually also put { } around the else-scope)

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12f143906818fd6b16e8783157cbb1eb51e49ffc
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at>
Gerrit-Assignee: neels <nhofmeyr at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at>
Gerrit-Reviewer: fixeria <vyanitskiy at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: neels <nhofmeyr at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Mon, 05 Jul 2021 21:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list