Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24600 )

Change subject: handover_ctrl: add control interface for handover settings
......................................................................


Patch Set 6:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/6/include/osmocom/bsc/handover_cfg.h 
File include/osmocom/bsc/handover_cfg.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/6/include/osmocom/bsc/handover_cfg.h@264 
PS6, Line 264: 		"handover2 min-free-slots tch-h\0") \
you should not need to include '\0' because a terminating nul is present in every string constant


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/6/src/osmo-bsc/handover_ctrl.c 
File src/osmo-bsc/handover_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/6/src/osmo-bsc/handover_ctrl.c@32 
PS6, Line 32: /* Verify a VTY command argument against its value specification, the value
Here we could add:

 In handover_cfg.h the config items are described in VTY syntax. To be able to use those here
 in the CTRL interface, we parse the config arguments like the VTY would.


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/6/src/osmo-bsc/handover_ctrl.c@73 
PS6, Line 73: CTRL_CMD_DEFINE(NAME, CTRL_CMD VTY_CMD_PREFIX VTY_CMD); \
Hm, I don't understand how this works.

so CTRL_CMD is mostly "", so the name becomes like

  "" "handover 2 " "power budget hysteresis"
  = "handover 2 power budget hysteresis"

But how about "handover2 min-free-slots tch-f"?
IIUC this should become

  "handover2 min-free-slots tch-f" "handover2 " "min-free-slots tch/f"
  = "handover2 min-free-slots tch-fhandover2 min-free-slots tch/f"


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/6/src/osmo-bsc/handover_ctrl.c@114 
PS6, Line 114: 		cmd->reply = talloc_asprintf(cmd, "%s", #DEFAULT_VAL); \
(we would usually also put { } around the else-scope)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12f143906818fd6b16e8783157cbb1eb51e49ffc
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Jul 2021 21:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210705/5e45f3e5/attachment.htm>