This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24823 ) Change subject: mgcp_protocol: add support for wildcarded DLCX ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c@1278 PS2, Line 1278: if (!endp->wildcarded_req && llist_count(&endp->conns) <= 0) { how can llist_count return < 0? I don't think it can. Morevoer, I guess you want to check if the list is not empty, so use !llist_empty() which doesn't iterate over the whole list like llist_count does. EDIT: I see it comes from existing code. However it may make sense to do the changes I mentioned as a separate commit perhaps. https://gerrit.osmocom.org/c/osmo-mgw/+/24823/2/src/libosmo-mgcp/mgcp_protocol.c@1350 PS2, Line 1350: return create_ok_response(endp, 200, "DLCX", p->trans); isn't endp released already in here since you released all the endpoints in the loop above? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0770cf46d93ab09efe9cafdd56d2e3f1132db189 Gerrit-Change-Number: 24823 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jul 2021 15:19:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210702/e582175c/attachment.htm>