This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22518 ) Change subject: stats: Add granularity to chan:rf_fail stat. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/22518/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/22518/1/src/osmo-bsc/abis_rsl.c@991 PS1, Line 991: lchan->ts->trx->bts->bts_ctrs->ctr that long chain of pointer de-references was "OK" if we used it only once. But as we now use it at three locatings in the function, I would generally suggest to have a temporary local stack variable for at least 'bts', if not 'bts_ctrs' and ten use that from the three log lines. Not super critical, just letting you know. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I91fe6659fe9df33763f4070b4f505561b2005d38 Gerrit-Change-Number: 22518 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael at kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 29 Jan 2021 21:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/9868831f/attachment.htm>