Change in osmo-pcu[master]: Introduce NACC support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jan 29 09:51:17 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22385 )

Change subject: Introduce NACC support
......................................................................


Patch Set 11: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/22385/11/src/nacc_fsm.c 
File src/nacc_fsm.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22385/11/src/nacc_fsm.c@633 
PS11, Line 633: connect to CTRL
> I am afraid this message may be confusing for the end user, because usually our osmo-apps are CTRL s […]
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h 
File src/neigh_cache.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h@49 
PS9, Line 49: 	struct llist_head list; /* to be included in neigh_cache->list */
> I would then need to hash quite complex keys, I'll have a look but I think I'll leave it as it is. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca
Gerrit-Change-Number: 22385
Gerrit-PatchSet: 11
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jan 2021 09:51:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210129/272b0704/attachment.htm>


More information about the gerrit-log mailing list