Change in osmo-pcu[master]: NACC: allow setting keep time for entries in neigh and si cache

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jan 28 19:02:33 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22449 )

Change subject: NACC: allow setting keep time for entries in neigh and si cache
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22449/3/src/gprs_pcu.c 
File src/gprs_pcu.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22449/3/src/gprs_pcu.c@36 
PS3, Line 36: 	{ .T=PCU_TDEF_NEIGH_CACHE_ALIVE,   .default_val=5,  .unit=OSMO_TDEF_S,   .desc="[ARFCN+BSIC]->[RAC+CI] resolution cache entry storage timeout (s)", .val=0 },
> Looks longer than 120 chars. I would move '.desc' to a new line.
Yes I know, but in this kind of tables I'm actually fine with keeping one item per line anyway. If you are others are really against it I can change it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22449
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ifa336aa27dd88ff5b78dbc5a2799740f542bb369
Gerrit-Change-Number: 22449
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 28 Jan 2021 19:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210128/bf25890b/attachment.htm>


More information about the gerrit-log mailing list