Change in osmo-bsc[master]: stats: Add granularity to chan:rf_fail stat.

[iedemam]

iedemam has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22518 )


Change subject: stats: Add granularity to chan:rf_fail stat.
......................................................................

stats: Add granularity to chan:rf_fail stat.

Add additional counters to track TCH and SDCCH RF failures in separate subcategories.

Change-Id: I91fe6659fe9df33763f4070b4f505561b2005d38
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bts.c
3 files changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/22518/1

diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 8f3e05b..b81f45f 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -28,6 +28,8 @@
 	BTS_CTR_CHREQ_SUCCESSFUL,
 	BTS_CTR_CHREQ_NO_CHANNEL,
 	BTS_CTR_CHAN_RF_FAIL,
+	BTS_CTR_CHAN_RF_FAIL_TCH,
+	BTS_CTR_CHAN_RF_FAIL_SDCCH,
 	BTS_CTR_CHAN_RLL_ERR,
 	BTS_CTR_BTS_OML_FAIL,
 	BTS_CTR_BTS_RSL_FAIL,
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 388e2fc..9e00fe7 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -982,6 +982,17 @@
 	LOG_LCHAN(lchan, LOGL_ERROR, "CONNECTION FAIL%s\n", rsl_cause_name(&tp));
 
 	rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL]);
+	switch (lchan->type) {
+	case GSM_LCHAN_SDCCH:
+		rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL_SDCCH]);
+		break;
+	case GSM_LCHAN_TCH_H:
+	case GSM_LCHAN_TCH_F:
+		rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL_TCH]);
+		break;
+	default:
+		break;
+	}
 
 	/* If the lchan is associated with a conn, we shall notify the MSC of the RSL Conn Failure, and
 	 * the connection will presumably be torn down and lead to an lchan release. During initial
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 3fa4f24..ac0e2af 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -791,6 +791,12 @@
 	[BTS_CTR_CHAN_RF_FAIL] = \
 		{ "chan:rf_fail",
 		  "Received a RF failure indication from BTS" },
+	[BTS_CTR_CHAN_RF_FAIL_TCH] = \
+		{ "chan:rf_fail_tch",
+		  "Received a RF failure indication from BTS on a TCH channel" },
+	[BTS_CTR_CHAN_RF_FAIL_SDCCH] = \
+		{ "chan:rf_fail_sdcch",
+		  "Received a RF failure indication from BTS on an SDCCH channel" },
 	[BTS_CTR_CHAN_RLL_ERR] = \
 		{ "chan:rll_err",
 		  "Received a RLL failure with T200 cause from BTS" },

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22518
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I91fe6659fe9df33763f4070b4f505561b2005d38
Gerrit-Change-Number: 22518
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210128/e905c232/attachment.htm>