Change in osmo-bsc[master]: lchan assignment when RTP is set up: don't break on Mode Modify

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22510 )


Change subject: lchan assignment when RTP is set up: don't break on Mode Modify
......................................................................

lchan assignment when RTP is set up: don't break on Mode Modify

Change-Id: I06d3f35fcc71d77e1f30c2b15ab221ef7d5f7f27
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/22510/1

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 6dba214..83822a1 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -434,8 +434,12 @@
 		return;
 
 	/* There may be an already existing lchan, if yes, try to work with
-	 * the existing lchan. */
-	if (reuse_existing_lchan(conn)) {
+	 * the existing lchan.
+	 * If an RTP FSM is already set up for the lchan, Mode Modify is not yet supported -- see handling of
+	 * LCHAN_EV_REQUEST_MODE_MODIFY in lchan_fsm.c. To not break the lchan, do not even attempt to re-use an lchan
+	 * that already has an RTP stream set up, rather establish a new lchan (that transition is well implemented). */
+	if (reuse_existing_lchan(conn)
+	    && !conn->lchan->fi_rtp) {
 
 		/* If the requested mode and the current TCH mode matches up, just send the
 		 * assignment complete directly and be done with the assignment procedure. */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22510
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I06d3f35fcc71d77e1f30c2b15ab221ef7d5f7f27
Gerrit-Change-Number: 22510
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210127/05e68a03/attachment.htm>