Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_nacc_outbound_success

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387 )

Change subject: pcu: Introduce test TC_nacc_outbound_success
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn 
File library/GSM_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/library/GSM_Types.ttcn@425 
PS3, Line 425: 		bcdmccmnc := str2hex(mcc_str[0]) & str2hex(mcc_str[1]) & str2hex(mnc_str[2]) &
why not one "mncc_str_hex := str2hex(mncc_str)" above and then avoid calling that function 9 times - plus make the code more readable?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3588 
PS3, Line 3588: while (true) {
              : 		f_rx_rlcmac_dl_block(dl_block, sched_fn);
              : 		if (not match(dl_block, tr_RLCMAC_DUMMY_CTRL())) {
              : 			break;
              : 		}
              : 		if (i > 50) {
              : 			setverdict(fail, "Rx unexpected DL block: ", dl_block);
              : 			f_shutdown(__BFILE__, __LINE__);
              : 			return;
              : 		}
              : 		i := i + 1;
              : 	}
does it make sense to factor this out into a separate function? something in principle like "wait_for(rx_template, max_num_iterations)"


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/3/pcu/PCU_Tests.ttcn@3609 
PS3, Line 3609: return
I guess that's not needed anywhere after f_shutdown()?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26
Gerrit-Change-Number: 22387
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 27 Jan 2021 10:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210127/10ffecf3/attachment.htm>