Change in osmo-pcu[master]: tbf: Drop always-true condition checking for MS

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22420 )

Change subject: tbf: Drop always-true condition checking for MS
......................................................................

tbf: Drop always-true condition checking for MS

The TBF can sometimes be detached from an MS, for eg. when switching
from one MS object to another due to them being merged after we found
duplicate objects upon receiving new information from it, but that
change is instantaneous so it shouldn't be a problem. The only other way
where an MS can be detached from an MS is during the end of its (or the
MS) life, where it is not sending data anymore.

Hence, it is safe to drop those checks for MS not being null. Those
being trigger, it should be considered a bug.

Change-Id: If292a53a09a64664031e756bff4735b9c6ee8651
---
M src/tbf.cpp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/tbf.cpp b/src/tbf.cpp
index 37af21f..248e8ef 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -196,16 +196,16 @@
 	enum CodingScheme cs;
 
 	if (direction == GPRS_RLCMAC_UL_TBF)
-		cs = m_ms ? ms_current_cs_ul(m_ms) : UNKNOWN;
+		cs = ms_current_cs_ul(m_ms);
 	else
-		cs = m_ms ? ms_current_cs_dl(m_ms) : UNKNOWN;
+		cs = ms_current_cs_dl(m_ms);
 
 	return cs;
 }
 
 gprs_llc_queue *gprs_rlcmac_tbf::llc_queue()
 {
-	return m_ms ? ms_llc_queue(m_ms) : NULL;
+	return ms_llc_queue(m_ms);
 }
 
 const gprs_llc_queue *gprs_rlcmac_tbf::llc_queue() const

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If292a53a09a64664031e756bff4735b9c6ee8651
Gerrit-Change-Number: 22420
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210126/5b973647/attachment.htm>