Change in osmo-pcu[master]: ms: Drop always-false check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jan 26 12:19:32 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22418 )

Change subject: ms: Drop always-false check
......................................................................

ms: Drop always-false check

MS is always assigned to a BTS, since it's set during MS constructor.
Hence, the check removed in this patch would never hold true (and if it
did, it'd be a bug).

Change-Id: I86a71c64623f7bec031226938a54306148370ffb
---
M src/gprs_ms.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index ea497a3..daa3223 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -242,9 +242,6 @@
 {
 	ms->mode = mode;
 
-	if (!ms->bts)
-		return;
-
 	switch (ms->mode) {
 	case GPRS:
 		if (!mcs_is_gprs(ms->current_cs_ul)) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I86a71c64623f7bec031226938a54306148370ffb
Gerrit-Change-Number: 22418
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210126/d3409b50/attachment.htm>


More information about the gerrit-log mailing list