Change in osmo-pcu[master]: Fix Dl EGPRS data blocks being generated occasionally on GPRS TBFs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jan 26 12:19:03 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22435 )

Change subject: Fix Dl EGPRS data blocks being generated occasionally on GPRS TBFs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22435/1/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/22435/1/src/tbf_dl.cpp@537 
PS1, Line 537: forced
> The meaning of "forced" changed here so make it more explicit like "forced data len"? […]
It's not really unrelated, I had to change it also because I was changing and fixing how the CS/MCS requirements are passed, it doesn't make sense moving it to another commit imho.

It's true that the condition in which this "forced" flag is printed changed a bit, but not the meaning of it. The important thing here is to remark that the CS/MCS to use was forced rather than its length. I'm simply reusing the fact that this variable is != -1 only when that happened (see start of the function).
The change in conditions for this variable to be changed is that it's no longer printed in the case where the CS/MCS was downgraded to meet scheduler requirements, but with the extension I think it's fine not printing force there, and only when we force the CS because it's the 2nd BSN encapsulated inside the same RLCMAC block.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22435
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic0276ce045660713129f0c72f1158a3321c5977f
Gerrit-Change-Number: 22435
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Jan 2021 12:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210126/4de29c4b/attachment.htm>


More information about the gerrit-log mailing list