Change in libosmocore[master]: gprs_bssgp_rim: add functions to convert a RIM-RI to a string

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jan 26 10:53:52 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22438 )

Change subject: gprs_bssgp_rim: add functions to convert a RIM-RI to a string
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22438/1/src/gb/gprs_bssgp_rim.c 
File src/gb/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/libosmocore/+/22438/1/src/gb/gprs_bssgp_rim.c@156 
PS1, Line 156: 	static __thread char rai_buf[32];
why don't you allocate these in the stack?


https://gerrit.osmocom.org/c/libosmocore/+/22438/1/src/gb/gprs_bssgp_rim.c@173 
PS1, Line 173: 			 osmo_rai_name2_buf(rai_buf, sizeof(rai_buf), &rai), ri->geran.cid);
There's osmo_cgi_ps_name family of APIs for this



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22438
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idca6bdccffe663aea71a0183ca3ea5bb5b59e702
Gerrit-Change-Number: 22438
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Jan 2021 10:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210126/68947182/attachment.htm>


More information about the gerrit-log mailing list