Change in osmo-bsc[master]: bsc_vty: fix acch_repetition ber threshold strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jan 22 20:46:48 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22120 )

Change subject: bsc_vty: fix acch_repetition ber threshold strings
......................................................................

bsc_vty: fix acch_repetition ber threshold strings

When setting the BER threshold for ACCH repetition the VTY displays
wrong threshold values in the online help.

Change-Id: I4c89ad130da328aba99663e5a2931a4007772bca
Related: SYS#5114
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 5b4417e..4781217 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -2832,13 +2832,14 @@
 	      REP_ACCH_STR
 	      "Set UL-SACCH/DL-FACCH rxqual threshold-ber\n"
 	      "0 disabled (always on)\n"
-	      "1 0.26% to 0.30% BER\n"
-	      "2 0.51% to 0.64% BER\n"
-	      "3 1.0% to 1.3% BER\n"
-	      "4 1.9% to 2.7% BER (default)\n"
-	      "5 3.8% to 5.4% BER\n"
-	      "6 7.6% to 11.0% BER\n"
-	      "7 Greater than 15.0% BER\n")
+	      "1 BER >= 0.2%\n"
+	      "2 BER >= 0.4%\n"
+	      "3 BER >= 0.8%\n"
+	      "4 BER >= 1.6%\n"
+	      "5 BER >= 3.2%\n"
+	      "6 BER >= 6.4%\n"
+	      "7 BER >= 12.8%\n")
+	      /* See also: GSM 05.08, section 8.2.4 */
 {
 	struct gsm_bts *bts = vty->index;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4c89ad130da328aba99663e5a2931a4007772bca
Gerrit-Change-Number: 22120
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/128b694d/attachment.htm>


More information about the gerrit-log mailing list