Change in osmo-pcu[master]: gprs_bssgp_rim: add serving BSS NACC application

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jan 22 20:42:17 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22368 )

Change subject: gprs_bssgp_rim: add serving BSS NACC application
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/gprs_bssgp_rim.c@208 
PS2, Line 208: BSSGP RIM (NSEI=%u)
we just had this in the review of another patch; please introduce and use something like #define LOGPRIM(nsei, lvl, fmt, args ...) LOGP(DRIM, lvl, "BSSGP RIM (NSEI=%u) " fmt, nsei, ## args)

As there is already code in master that open-codes this in every log statement, please submit an incremental patch on top which cleans this up, for all of the code. Thanks.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22368
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id72118120c14984d2fb1b918b41fac4868150d41
Gerrit-Change-Number: 22368
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Jan 2021 20:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/b1f07312/attachment.htm>


More information about the gerrit-log mailing list