Change in osmo-ttcn3-hacks[master]: WIP: NACC

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387 )

Change subject: WIP: NACC
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/1/pcu/PCU_Tests.ttcn@3658 
PS1, Line 3658: TC_nacc
might make sense to give the test a more specific name, as for sure we will have many more tests.  The name should at the very least imply that it is about "outbound" NACC.

Also, the comment above should indicate that.  Of course all NACC tests will tet NACC - but is it inbound/outbound? successful or error case? ...


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387/1/pcu/PCU_Tests.ttcn@3673 
PS1, Line 3673: 	var BssgpCellId src := valueof(ts_BssgpCellId(ts_RAI(ts_LAI('262F42'H, /* TODO: encode from info_ind */
> self note: I still need to add some sort of function "convert_plmn_to_hexstr(integer mcc, integer mn […]
I guess something like oct2hex(f_enc_mcc_mnc(mcc, mnc)) should work

and f_enc_mcc_mnc() must be made non-private and moved from BSSMAP_Templates.ttcn to a more general module.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I951db4af731e5a7c207f0f407dd78d166e2d3d26
Gerrit-Change-Number: 22387
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 22 Jan 2021 20:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/78eb8d27/attachment.htm>