Change in osmo-pcu[master]: Initial handling support for RIM messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Jan 22 15:39:03 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22364 )

Change subject: Initial handling support for RIM messages
......................................................................


Patch Set 3:

(6 comments)

Thanks for reviewing. I have now reworked the missing bits.

https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_pcu.c 
File src/gprs_bssgp_pcu.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_pcu.c@a554 
PS3, Line 554: 		break;
> Looks like this break was not removed intentionally, handle_rim() will assert on SAP_BSSGP_NM.
yes, it probably makes no sense to let PDUs for NM into the RIM handlers...


https://gerrit.osmocom.org/c/osmo-pcu/+/22364/2/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22364/2/src/gprs_bssgp_rim.c@116 
PS2, Line 116: 		   
> Why should an UMTS or LTE cell not be able to ask us for NACC related information? As far as I under […]
Thats indeed true. I will drop the check for the source.


https://gerrit.osmocom.org/c/osmo-pcu/+/22364/2/src/gprs_bssgp_rim.c@128 
PS2, Line 128: 		retu
> I'm resubmitting the math fixing all the comments except this, one. […]
This is indeed a bit confisuing, I added a comment to explain it a bit better.


https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c@91 
PS3, Line 91: certian
> (certain)
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c@127 
PS3, Line 127: /* FIXME: send RIM error instead */
> If I read the spec right (8c.3.1. […]
I have put a spec ref now. This indeed a bit confusing. The RIM container is more like a payload that is handled by the various RIM applications, but when a RIM PDU is routed the layer responsible for routing is not looking into the container, so if the routing destination is wrong, you would expect the error message from the routing layer, not from the RIM application and as there is no cause code IE or something but only the routing information IEs in above the RIM container, BSSGP is used for that. Thats at least how I explain it to me.


https://gerrit.osmocom.org/c/osmo-pcu/+/22364/3/src/gprs_bssgp_rim.c@161 
PS3, Line 161: failes
> (fails)
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22364
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ade0e97ea781ec655439c008b6cefaf3e90dec
Gerrit-Change-Number: 22364
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Jan 2021 15:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210122/a9b1aa81/attachment.htm>


More information about the gerrit-log mailing list