Change in osmo-sgsn[master]: gbproxy: Fix radio status routing by TMSI

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22363 )


Change subject: gbproxy: Fix radio status routing by TMSI
......................................................................

gbproxy: Fix radio status routing by TMSI

If a radio status message contains a TMSI it should be routed as if it
was a TLLI. Convert the TMSI to (foreign) TLLI so NRI-routing works.

Both foreign and local TLLIs are routed the same.

Fixes: OS#4954
Change-Id: Ifd64f02fa16b44f8e2e19eb8ba973f50a829ead5
---
M src/gbproxy/gb_proxy.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/63/22363/1

diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index be8602e..99efa4e 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -417,11 +417,12 @@
 		} else if (TLVP_PRESENT(&tp, BSSGP_IE_TMSI)) {
 			/* we treat the TMSI like a TLLI and extract the NRI from it */
 			tlli = osmo_load32be(TLVP_VAL(&tp, BSSGP_IE_TMSI));
+			/* Convert the TMSI into a FOREIGN TLLI so it is routed appropriately */
+			tlli = gprs_tmsi2tlli(tlli, TLLI_FOREIGN);
 			rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, &tlli, false);
 		} else if (TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) {
 			/* FIXME: Use the IMSI as selector? */
 			rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, NULL, false);
-			/* rc = gbprox_bss2sgsn_hashed(bss_bvc->cell, msg, NULL); */
 		} else
 			LOGPBVC(bss_bvc, LOGL_ERROR, "Rx RADIO-STATUS without any of the conditional IEs\n");
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ifd64f02fa16b44f8e2e19eb8ba973f50a829ead5
Gerrit-Change-Number: 22363
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210121/4a14c841/attachment.htm>