Change in libosmocore[master]: configure.ac: set -std=gnu89

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Jan 21 12:09:37 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22355 )

Change subject: configure.ac: set -std=gnu89
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> Just in case you didn't see it, there was also a recent thread about it in ML:
> 
> https://lists.osmocom.org/pipermail/openbsc/2021-January/013360.html
> 
> I think it probably makes sense to keep an older std for libosmocore since it's morprobable to have that in embedded systems which may lack proper/updated C compiler.

Thanks, I didn't see this thread. Adding lynxis as reviewer.

lynxis recommended c99 in the thread. Personally I don't have a strong opinion on which standard to use, but I would welcome if we do decide on one, at least for the purpose to avoid build failures on OBS. Right now we are enforcing gnu89 indirectly by correcting whenever debian 8 fails to build on OBS, which has it set as default, and we do have gnu89 set as standard in osmo-pcu already (see related patch).


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22355
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id79b13d3c498acb565f91eba650328fccb5a13ef
Gerrit-Change-Number: 22355
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Jan 2021 12:09:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210121/d9bd2105/attachment.htm>


More information about the gerrit-log mailing list