Change in libosmocore[master]: gprs_ns2: rework logging of Rx and Tx NS PDU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jan 21 09:29:37 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22294 )

Change subject: gprs_ns2: rework logging of Rx and Tx NS PDU
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22294/11/src/gb/gprs_ns2_internal.h 
File src/gb/gprs_ns2_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/22294/11/src/gb/gprs_ns2_internal.h@33 
PS11, Line 33: #define LOG_NS_TX_MESSAGE(nsvc, pdu_type) LOG_NS_MESSAGE(nsvc, "Tx", pdu_type, LOGL_INFO, "\n")
> Could you log NS_PDUT_UNITDATA as LOGL_DEBUG, but everything else INFO? Otherwise I fear the logs ar […]
we could also introduce separate logging sub-systems for data and user plane?  Or have log filters for that?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22294
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I34b8fde2955ecc010d1dcd9512e1bba9211e2c0d
Gerrit-Change-Number: 22294
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Jan 2021 09:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210121/07dc2911/attachment.htm>


More information about the gerrit-log mailing list