Change in osmo-hlr[master]: Add vty command to show summary of all or filtered subscribers

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/22311 )

Change subject: Add vty command to show summary of all or filtered subscribers
......................................................................


Patch Set 9:

(7 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/db_hlr.c 
File src/db_hlr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/db_hlr.c@629 
PS7, Line 629:  
> there is no  vty argument in below function
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/db_hlr.c@633 
PS7, Line 633:  
> meh, sorry. forgot to update these..
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c 
File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@232 
PS7, Line 232: vty_out(vty, "-----  ------------  ----------------  ----------------  -----");
             : 		if (show_ls)
             : 			vty_out(vty, "  ------------");
             : 		vty_out_newline(vty);
             : 		vty_out(vty, "ID     MSISDN        IMSI              IMEI              NAM");
             : 		if (show_ls)
             : 			vty_out(vty, "    LAST SEEN");
             : 		vty_out_newline(vty);
> yes, please go for that function, if required with reversed lines. […]
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@251 
PS7, Line 251: SUBSCR_SHOW_HELP
> works for me.
Ack


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@305 
PS7, Line 305: SHOW_STR SUBSCRS_SHOW_HELP "Show summary of subscribers with filter\n"
             :       "Filter by IMSI\n" "Filter by MSISDN\n" "String to match in msisdn or imsi\n")
> My understanding of the existing logic (the code before I edited it) was that anything appearing mor […]
Ack


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@320 
PS7, Line 320:      
> This doesn't make sense: […]
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/22311/7/src/hlr_vty_subscr.c@323 
PS7, Line 323: last seen
> I personally don't think there are other tokens after last and hence would like to see last-seen.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/22311
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I7f0573381a6d0d13841ac6d42d50f0e8389decf4
Gerrit-Change-Number: 22311
Gerrit-PatchSet: 9
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Jan 2021 22:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210120/3ff2627b/attachment.htm>