Change in osmo-bts[master]: vty: make commands related to the loopback mode hidden

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jan 20 21:35:51 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/22347 )


Change subject: vty: make commands related to the loopback mode hidden
......................................................................

vty: make commands related to the loopback mode hidden

The loopback mode was added for testing, and may be dangerous if
enabled in production.  Let's make it appear only in hidden mode,
and take this chance to indicate that it applies immediately.

Change-Id: I3f68acd7f2b0231f78516f59fb5e8ef56fb69dbf
---
M src/common/vty.c
1 file changed, 10 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/22347/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 846ba4a..fd8b3c8 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1988,10 +1988,11 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(bts_t_t_l_loopback,
-	bts_t_t_l_loopback_cmd,
-	BTS_T_T_L_CMD " loopback",
-	BTS_T_T_L_STR "Set loopback\n")
+DEFUN_ATTR(bts_t_t_l_loopback,
+	   bts_t_t_l_loopback_cmd,
+	   BTS_T_T_L_CMD " loopback",
+	   BTS_T_T_L_STR "Set loopback\n",
+	   CMD_ATTR_HIDDEN | CMD_ATTR_IMMEDIATE)
 {
 	struct gsm_network *net = gsmnet_from_vty(vty);
 	struct gsm_lchan *lchan;
@@ -2006,10 +2007,11 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(no_bts_t_t_l_loopback,
-	no_bts_t_t_l_loopback_cmd,
-	"no " BTS_T_T_L_CMD " loopback",
-	NO_STR BTS_T_T_L_STR "Set loopback\n")
+DEFUN_ATTR(no_bts_t_t_l_loopback,
+	   no_bts_t_t_l_loopback_cmd,
+	   "no " BTS_T_T_L_CMD " loopback",
+	   NO_STR BTS_T_T_L_STR "Set loopback\n",
+	   CMD_ATTR_HIDDEN | CMD_ATTR_IMMEDIATE)
 {
 	struct gsm_network *net = gsmnet_from_vty(vty);
 	struct gsm_lchan *lchan;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3f68acd7f2b0231f78516f59fb5e8ef56fb69dbf
Gerrit-Change-Number: 22347
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210120/c22e7b2a/attachment.htm>


More information about the gerrit-log mailing list