Change in libosmocore[master]: gprs_bssgp_rim: fix bug in dub_tlvp_header()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22339 )

Change subject: gprs_bssgp_rim: fix bug in dub_tlvp_header()
......................................................................

gprs_bssgp_rim: fix bug in dub_tlvp_header()

When the length field is written the function writes the lower and the
higher half of the length at the same position, so the higher half is
overwritten with the lower half, this is wrong.

Change-Id: I3cce0b2796793554a421fd3ce8e749c52d22eaea
Related: CID#216670
Related: SYS#5103
---
M src/gb/gprs_bssgp_rim.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 2096977..23fb3a0 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -438,7 +438,7 @@
 	} else {
 		memmove(buf_ptr + 1, buf_ptr, len);
 		buf_ptr[1] = len >> 8;
-		buf_ptr[1] = len & 0xff;
+		buf_ptr[2] = len & 0xff;
 		buf_ptr += TVLV_HDR_MAXLEN;
 	}
 	buf_ptr += len;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3cce0b2796793554a421fd3ce8e749c52d22eaea
Gerrit-Change-Number: 22339
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210120/c4e7c4da/attachment.htm>