This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22196 ) Change subject: Unify BTS into a C usable structure ...................................................................... Patch Set 6: (9 comments) Found some minor things, otherwise +1. Well done, Pau! https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.h File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.h@199 PS6, Line 199: uint16_t mcs_mask; /* Allowed MCS mask from struct gprs_rlcmac_bts */ "from BTS" -> "from struct gprs_rlcmac_bts" looks like unintentional replacement. Or if not, what do you mean with it? https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.h@227 PS6, Line 227: // BTS: Looks like this "// BTS:" comment separates old C and C++ code. Did you intend to leave that in? (if so: different comment style, make it more descriptive?) https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.h@264 PS6, Line 264: void bts_set_current_frame_number(struct gprs_rlcmac_bts *bts, int frame_number); What about the 'TODO: change the number to unsigned' comment that was removed? https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.h@271 PS6, Line 271: int bts_tfi_find_free(const struct gprs_rlcmac_bts *bts, enum gprs_rlcmac_tbf_direction dir, uint8_t *_trx, int8_t use_trx); (line > 120 characters) https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/bts.cpp@569 PS6, Line 569: int bts_tfi_find_free(const struct gprs_rlcmac_bts *bts, enum gprs_rlcmac_tbf_direction dir, uint8_t *_trx, int8_t use_trx) (line too long) https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/pdch.cpp@116 PS6, Line 116: static inline void sched_ul_ass_or_rej(struct gprs_rlcmac_bts *bts, gprs_rlcmac_bts *bts_data, struct gprs_rlcmac_dl_tbf *tbf) (long line) https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/src/pdch.cpp@708 PS6, Line 708: bts_send_gsmtap_meas(bts(), PCU_GSMTAP_C_UL_CTRL, true, trx_no(), ts_no, GSMTAP_CHANNEL_PACCH, fn, data, data_len, meas); (while add it, add line breaks in both lines?) https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/tests/app_info/AppInfoTest.cpp File tests/app_info/AppInfoTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/tests/app_info/AppInfoTest.cpp@158 PS6, Line 158: /* FIXME: talloc report disabled, because bts_alloc_ms(bts, ) in prepare_bts_with_two_dl_tbf_subscr() causes leak */ (long line) https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/22196/6/tests/tbf/TbfTest.cpp@2206 PS6, Line 2206: bts = bts; bts = bts ? ;) $ git grep -n 'bts = bts;' ... tests/alloc/AllocTest.cpp:467: bts = bts; tests/app_info/AppInfoTest.cpp:86: bts = bts; tests/edge/EdgeTest.cpp:1158: bts = bts; tests/tbf/TbfTest.cpp:487: bts = bts; tests/tbf/TbfTest.cpp:533: bts = bts; tests/tbf/TbfTest.cpp:692: bts = bts; tests/tbf/TbfTest.cpp:838: bts = bts; tests/tbf/TbfTest.cpp:1272: bts = bts; tests/tbf/TbfTest.cpp:1587: bts = bts; tests/tbf/TbfTest.cpp:2206: bts = bts; tests/tbf/TbfTest.cpp:2271: bts = bts; tests/tbf/TbfTest.cpp:2318: bts = bts; tests/tbf/TbfTest.cpp:2401: bts = bts; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7d12c896c5ded659ca9d3bff4cf3a3fc857db9dd Gerrit-Change-Number: 22196 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jan 2021 14:40:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210119/16f527c3/attachment.htm>