Change in osmo-bsc[master]: cosmetic: in a ho test, use '*' instead of pdch

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Jan 19 10:50:42 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22262 )

Change subject: cosmetic: in a ho test, use '*' instead of pdch
......................................................................

cosmetic: in a ho test, use '*' instead of pdch

The idea is to avoid confusion between the static PDCH and the dynamic
timeslots. The PDCH is always in 'pdch' mode, while the dynamic
timeslots are 'pdch' when they are not occupied by any TCH.

Change-Id: I1a12518d85ed891c491723e7f03f5bdd4fad980f
---
M tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty b/tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty
index f94ad0e..85b00e8 100644
--- a/tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty
+++ b/tests/handover/test_dyn_ts_amr_tch_f_to_h_congestion_assignment.ho_vty
@@ -19,59 +19,59 @@
 
 create-ms bts 0 TCH/F AMR
 meas-rep lchan 0 0 5 0 rxlev 40 rxqual 0 ta 0 neighbors 30
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/F TCH/F pdch pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/F TCH/F pdch *
 
 congestion-check
 expect-ho from lchan 0 0 5 0 to lchan 0 0 6 0
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/F pdch TCH/H- pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/F pdch TCH/H- *
 
 congestion-check
 expect-ho from lchan 0 0 4 0 to lchan 0 0 6 1
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F pdch pdch TCH/HH pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F pdch pdch TCH/HH *
 
 congestion-check
 expect-no-chan
 
 create-ms bts 0 TCH/F AMR
 meas-rep lchan 0 0 4 0 rxlev 40 rxqual 0 ta 0 neighbors 30
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/F pdch TCH/HH pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/F pdch TCH/HH *
 
 congestion-check
 expect-ho from lchan 0 0 4 0 to lchan 0 0 5 0
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F pdch TCH/H- TCH/HH pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F pdch TCH/H- TCH/HH *
 
 congestion-check
 expect-ho from lchan 0 0 1 0 to lchan 0 0 5 1
-expect-ts-use trx 0 0 states * - TCH/F TCH/F pdch TCH/HH TCH/HH pdch
+expect-ts-use trx 0 0 states * - TCH/F TCH/F pdch TCH/HH TCH/HH *
 
 congestion-check
 expect-no-chan
 
 create-ms bts 0 TCH/F AMR
 meas-rep lchan 0 0 1 0 rxlev 40 rxqual 0 ta 0 neighbors 30
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F pdch TCH/HH TCH/HH pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F pdch TCH/HH TCH/HH *
 
 congestion-check
 expect-ho from lchan 0 0 1 0 to lchan 0 0 4 0
-expect-ts-use trx 0 0 states * - TCH/F TCH/F TCH/H- TCH/HH TCH/HH pdch
+expect-ts-use trx 0 0 states * - TCH/F TCH/F TCH/H- TCH/HH TCH/HH *
 
 congestion-check
 expect-ho from lchan 0 0 2 0 to lchan 0 0 4 1
-expect-ts-use trx 0 0 states * - - TCH/F TCH/HH TCH/HH TCH/HH pdch
+expect-ts-use trx 0 0 states * - - TCH/F TCH/HH TCH/HH TCH/HH *
 
 congestion-check
 expect-no-chan
 
 create-ms bts 0 TCH/F AMR
 meas-rep lchan 0 0 1 0 rxlev 40 rxqual 0 ta 0 neighbors 30
-expect-ts-use trx 0 0 states * TCH/F - TCH/F TCH/HH TCH/HH TCH/HH pdch
+expect-ts-use trx 0 0 states * TCH/F - TCH/F TCH/HH TCH/HH TCH/HH *
 
 congestion-check
 expect-no-chan
 
 create-ms bts 0 TCH/F AMR
 meas-rep lchan 0 0 2 0 rxlev 40 rxqual 0 ta 0 neighbors 30
-expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/HH TCH/HH TCH/HH pdch
+expect-ts-use trx 0 0 states * TCH/F TCH/F TCH/F TCH/HH TCH/HH TCH/HH *
 
 congestion-check
 expect-no-chan

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1a12518d85ed891c491723e7f03f5bdd4fad980f
Gerrit-Change-Number: 22262
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210119/6d300475/attachment.htm>


More information about the gerrit-log mailing list