Change in libosmocore[master]: gprs_ns2: when calling nsvc_force_unconf for a dynamic NSE drop the NSE.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Jan 18 10:37:44 UTC 2021


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22200 )

Change subject: gprs_ns2: when calling nsvc_force_unconf for a dynamic NSE drop the NSE.
......................................................................

gprs_ns2: when calling nsvc_force_unconf for a dynamic NSE drop the NSE.

The vty command is used for test cases to reset NSE state.
So dynamic NSE shouldn't present.

Related: SYS#5208
Change-Id: I0a4f35c974c8c3b79c48f2f56170722c95254332
---
M src/gb/gprs_ns2_vty2.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/gb/gprs_ns2_vty2.c b/src/gb/gprs_ns2_vty2.c
index 41daa74..5af8fbc 100644
--- a/src/gb/gprs_ns2_vty2.c
+++ b/src/gb/gprs_ns2_vty2.c
@@ -1491,7 +1491,9 @@
 		return CMD_WARNING;
 	}
 
-	if (nse->dialect == NS2_DIALECT_SNS) {
+	if (!nse->persistent) {
+		gprs_ns2_free_nse(nse);
+	} else if (nse->dialect == NS2_DIALECT_SNS) {
 		gprs_ns2_free_nsvcs(nse);
 	} else {
 		/* Perform the operation for all nsvc */

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22200
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0a4f35c974c8c3b79c48f2f56170722c95254332
Gerrit-Change-Number: 22200
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210118/881955ce/attachment.htm>


More information about the gerrit-log mailing list