This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22232 ) Change subject: gsm_data: return early if MS Power class remains the same ...................................................................... gsm_data: return early if MS Power class remains the same The following message makes no sense: DRLL DEBUG gsm_data.c:844 MS Power class update: 4 -> 4 because nothing really changed, MS Power class remains 4. Neither it makes sense to call lchan_update_ms_power_ctrl_level(). Change-Id: I519d2d1575cbb5352cc381a60513db8e0e2cb0a0 --- M src/osmo-bsc/gsm_data.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 38392fc..916ba68 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -841,6 +841,11 @@ void conn_update_ms_power_class(struct gsm_subscriber_connection *conn, uint8_t power_class) { struct gsm_bts *bts = conn_get_bts(conn); + + /* MS Power class remains the same => do nothing */ + if (power_class == conn->ms_power_class) + return; + LOGP(DRLL, LOGL_DEBUG, "MS Power class update: %" PRIu8 " -> %" PRIu8 "\n", conn->ms_power_class, power_class); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I519d2d1575cbb5352cc381a60513db8e0e2cb0a0 Gerrit-Change-Number: 22232 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210117/306d97b9/attachment.htm>