Change in libosmocore[master]: gprs_ns2_vc: answer UNBLOCK on unblocked nsvc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Jan 14 20:26:49 UTC 2021


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22199 )


Change subject: gprs_ns2_vc: answer UNBLOCK on unblocked nsvc
......................................................................

gprs_ns2_vc: answer UNBLOCK on unblocked nsvc

48.016 7.2: says an UNBLOCK pdu should be answered with UNBLOCK_ACK on
already unblocked NSVC

Change-Id: Ic92e99b2607d1e54ecb4668667065502a55a2ce0
---
M src/gb/gprs_ns2_vc_fsm.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/22199/1

diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index d5f134e..78b0691 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -334,6 +334,9 @@
 	struct gprs_ns2_vc_priv *priv = fi->priv;
 
 	switch (event) {
+	case GPRS_NS2_EV_UNBLOCK:
+		ns2_tx_unblock_ack(priv->nsvc);
+		break;
 	case GPRS_NS2_EV_BLOCK:
 		priv->initiate_block = false;
 		ns2_tx_block_ack(priv->nsvc);
@@ -400,7 +403,8 @@
 		.onenter = gprs_ns2_st_blocked_onenter,
 	},
 	[GPRS_NS2_ST_UNBLOCKED] = {
-		.in_event_mask = S(GPRS_NS2_EV_BLOCK) | S(GPRS_NS2_EV_UNBLOCK_ACK),
+		.in_event_mask = S(GPRS_NS2_EV_BLOCK) | S(GPRS_NS2_EV_UNBLOCK_ACK) |
+				 S(GPRS_NS2_EV_UNBLOCK),
 		.out_state_mask = S(GPRS_NS2_ST_RESET) | S(GPRS_NS2_ST_ALIVE) |
 				  S(GPRS_NS2_ST_BLOCKED) |
 				  S(GPRS_NS2_ST_UNCONFIGURED),

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22199
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic92e99b2607d1e54ecb4668667065502a55a2ce0
Gerrit-Change-Number: 22199
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210114/78b5b18a/attachment.htm>


More information about the gerrit-log mailing list