This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/22174 ) Change subject: tests/hnb-test: Fix uninitialized use of rc variable ...................................................................... tests/hnb-test: Fix uninitialized use of rc variable Change-Id: I168e4f7cd48cbaa387e6b05868107250795a0f0c --- M src/tests/hnb-test.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c index 4696e80..4650a90 100644 --- a/src/tests/hnb-test.c +++ b/src/tests/hnb-test.c @@ -478,7 +478,7 @@ msg->data, msgb_length(msg), 0, 0); if (dec_ret.code != RC_OK) { LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); - return rc; + return -EINVAL; } if (pdu->present != HNBAP_PDU_PR_successfulOutcome) { @@ -506,14 +506,13 @@ { RUA_RUA_PDU_t _pdu, *pdu = &_pdu; asn_dec_rval_t dec_ret; - int rc; memset(pdu, 0, sizeof(*pdu)); dec_ret = aper_decode(NULL, &asn_DEF_RUA_RUA_PDU, (void **) &pdu, msg->data, msgb_length(msg), 0, 0); if (dec_ret.code != RC_OK) { LOGP(DMAIN, LOGL_ERROR, "Error in ASN.1 decode\n"); - return rc; + return -EINVAL; } switch (pdu->present) { @@ -560,7 +559,7 @@ break; } - return rc; + return 0; } static int hnb_read_cb(struct osmo_fd *fd) -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/22174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168e4f7cd48cbaa387e6b05868107250795a0f0c Gerrit-Change-Number: 22174 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210114/3747685c/attachment.htm>