This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21863 ) Change subject: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bssgp_rim ...................................................................... Patch Set 11: (2 comments) Thanks for reviewing. https://gerrit.osmocom.org/c/libosmocore/+/21863/9/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21863/9/src/gb/gprs_bssgp_rim.c@56 PS9, Line 56: ri->discr = buf[0] & 0x0f; > probably better doing buf++ here and then avoid using buf +1 everywhere after this point. I think this makes sense. https://gerrit.osmocom.org/c/libosmocore/+/21863/9/src/gb/gprs_bssgp_rim.c@127 PS9, Line 127: return ri->eutran.global_enb_id_len + 6; > you are missing 1 byte here I think, at least if you compare it to other switch cases. I think its correct. (1b discr) + (3b mcc/mnc) + (2b tac) + (enb id len) = 6 + (enb id len) Or do I miss something? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd667f41d5735de56cd9fb257670337c679dd258 Gerrit-Change-Number: 21863 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jan 2021 11:37:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210114/cb10846f/attachment.htm>