Change in osmo-bts[master]: power_control: do not print BS power parameters for C0/TRX0

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/22166 )


Change subject: power_control: do not print BS power parameters for C0/TRX0
......................................................................

power_control: do not print BS power parameters for C0/TRX0

BS power control is *not* allowed on C0/TRX, so the L1SAP layer
would not even feed the BS power loop with Downlink measurement
reports coming from the MS (see [1]).  Although, the VTY would
still show BS power parameters for C0/TRX:

  OsmoBTS# show lchan
  BTS 0, TRX 0, Timeslot 1, Lchan 0: Type SDCCH
    ...
    BS (Downlink) Power Control (static mode):
      Channel reduction: 6 dB
      TRX reduction: 10 dB
      Actual / Nominal power: -3 dBm / 13 dBm

This is extremely confusing, especially the last line showing that
the attenuation value is currently applied, despite it's not.

Let's do not print BS power control information for C0/TRX0, even
if the BSC has sent them in the channel activation message [2].

[1] I4fdfe097ae6f9edde5f39ed4da8a559a14b3b38f
[2] If8507992dfd90ade1edda99b72bf2420a702ccd5

Change-Id: I51b2def8c752215d1b89a6b0000bfb15c49db27e
Related: SYS#4918
---
M src/common/vty.c
1 file changed, 12 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/22166/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 689ae58..01578e7 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1292,11 +1292,14 @@
 		trx->nominal_power, trx->max_power_red,
 		trx->nominal_power - trx->max_power_red, VTY_NEWLINE);
 
-	vty_out(vty, "  BS Power control parameters (%s):%s",
-		trx->bs_dpc_params == &trx->bts->bs_dpc_params ?
-			"fall-back" : "from BSC",
-		VTY_NEWLINE);
-	dump_dpc_params(vty, 4, trx->bs_dpc_params);
+	/* BS power control shall not be used on C0/TRX0 */
+	if (trx->bts->c0 != trx) {
+		vty_out(vty, "  BS Power control parameters (%s):%s",
+			trx->bs_dpc_params == &trx->bts->bs_dpc_params ?
+				"fall-back" : "from BSC",
+			VTY_NEWLINE);
+		dump_dpc_params(vty, 4, trx->bs_dpc_params);
+	}
 
 	vty_out(vty, "  MS Power control parameters (%s):%s",
 		trx->ms_dpc_params == &trx->bts->ms_dpc_params ?
@@ -1489,6 +1492,10 @@
 	const struct lchan_power_ctrl_state *st = &lchan->bs_power_ctrl;
 	const struct gsm_bts_trx *trx = lchan->ts->trx;
 
+	/* BS power control shall not be used on C0/TRX0 */
+	if (trx == trx->bts->c0)
+		return;
+
 	cfg_out(vty, "BS (Downlink) Power Control (%s mode):%s",
 		st->dpc_params ? "dynamic" : "static", VTY_NEWLINE);
 	indent += 2;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22166
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I51b2def8c752215d1b89a6b0000bfb15c49db27e
Gerrit-Change-Number: 22166
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/126ad58c/attachment.htm>