Change in docker-playground[master]: fpga-build: don't write path to /etc/environment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Jan 13 14:58:31 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22136 )

Change subject: fpga-build: don't write path to /etc/environment
......................................................................

fpga-build: don't write path to /etc/environment

PATH isn't overwritten anymore when jenkins runs docker in osmo-ci.git's
master-builds.yml / gerrit-verifications.yml, therefore we can remove
this hack.

Change-Id: I5bff98f7af1a2f2de88c8d96d1e30de960057d01
---
M fpga-build/Dockerfile
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  osmith: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/fpga-build/Dockerfile b/fpga-build/Dockerfile
index a46641c..135af71 100644
--- a/fpga-build/Dockerfile
+++ b/fpga-build/Dockerfile
@@ -37,9 +37,6 @@
 RUN	mkdir /build
 RUN	chown build:build /build
 
-# ENV doesn't worrk for other users
-RUN	echo "PATH=/opt/fpga-toolchain/bin:/opt/xpack-riscv-none-embed-gcc-${RISCV_TOOLCHAIN_VER}/bin:\$PATH" >> /etc/environment
-
 ENV	PATH=/opt/fpga-toolchain/bin:/opt/xpack-riscv-none-embed-gcc-${RISCV_TOOLCHAIN_VER}/bin:${PATH}
 
 # Install osmo-ci.git/scripts to /usr/local/bin

-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22136
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I5bff98f7af1a2f2de88c8d96d1e30de960057d01
Gerrit-Change-Number: 22136
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/e1d3822c/attachment.htm>


More information about the gerrit-log mailing list