This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21848 ) Change subject: Introduce Neighbor Resolution Service ...................................................................... Patch Set 8: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21848/8/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21848/8/src/osmo-bsc/neighbor_ident_vty.c@89 PS8, Line 89: #define CGI_PS_DOC "Neighbor cell by cgi (Packet Switch, with RAC)\n" "MCC\n" "MNC\n" "LAC\n" "RAC\n" "CI\n" > "Packet Switched", or "PS Domain", but "Packet Switch" sounds like you're talking about an actual de […] Ack https://gerrit.osmocom.org/c/osmo-bsc/+/21848/8/src/osmo-bsc/neighbor_ident_vty.c@581 PS8, Line 581: neighbor > "neighbor-resolution bind" would be more self-explanatory, IMHO. Not critical. Ack https://gerrit.osmocom.org/c/osmo-bsc/+/21848/8/src/osmo-bsc/neighbor_ident_vty.c@583 PS8, Line 583: "IPv4 address to bind the service to\n" "IPv6 address to bind the service to\n > don't we have some #defines for this aleady? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379 Gerrit-Change-Number: 21848 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 13 Jan 2021 13:57:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/8eed1096/attachment.htm>