Change in libosmocore[master]: tlv_parser: Fix various out-of-bounds accesses

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 12 17:17:55 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22113 )

Change subject: tlv_parser: Fix various out-of-bounds accesses
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22113/1/src/gsm/tlv_parser.c 
File src/gsm/tlv_parser.c:

https://gerrit.osmocom.org/c/libosmocore/+/22113/1/src/gsm/tlv_parser.c@257 
PS1, Line 257: if (buf_len < 1)
             : 			return OSMO_TLVP_ERR_OFS_BEYOND_BUFFER;
actually, we can move this right to the top.  If we odn't have a single byte, there's nothing we can do in either case.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I98b02c914c9e3ecf56050af846292aa6979d7508
Gerrit-Change-Number: 22113
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 12 Jan 2021 17:17:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210112/d058c5bc/attachment.htm>


More information about the gerrit-log mailing list