Change in libosmocore[master]: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bs...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jan 12 15:49:27 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21863 )

Change subject: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bssgp_rim
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21863/9/src/gb/gprs_bssgp_rim.c 
File src/gb/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/libosmocore/+/21863/9/src/gb/gprs_bssgp_rim.c@56 
PS9, Line 56: 	ri->discr = buf[0] & 0x0f;
probably better doing buf++ here and then avoid using buf +1 everywhere after this point.


https://gerrit.osmocom.org/c/libosmocore/+/21863/9/src/gb/gprs_bssgp_rim.c@127 
PS9, Line 127: 		return ri->eutran.global_enb_id_len + 6;
you are missing 1 byte here I think, at least if you compare it to other switch cases.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21863
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd667f41d5735de56cd9fb257670337c679dd258
Gerrit-Change-Number: 21863
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Jan 2021 15:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210112/cbe28da1/attachment.htm>


More information about the gerrit-log mailing list