Change in osmo-bsc[master]: stats: Add granularity to SDCCH/TCH/LU activity.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 12 08:25:25 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22103 )

Change subject: stats: Add granularity to SDCCH/TCH/LU activity.
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c 
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c@543 
PS1, Line 543: case GSM48_CMODE_SIGN:
             : 			rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_NO_CHANNEL_SDCCH]);
             : 			break;
             : 		case GSM48_CMODE_SPEECH_V1:
             : 		case GSM48_CMODE_SPEECH_EFR:
             : 		case GSM48_CMODE_SPEECH_AMR:
             : 			rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_NO_CHANNEL_TCH]);
             : 			break;
> It may be perfectly legal but is it common? In my admittedly limited testing of these counters it al […]
It is implementation dependent.  I think OsmoBSC for example allocates TCH in SIGN mode if we're out of SDCCH but the MSC is asking for more signaling channels (e.g. for SMS delivery).

Maybe in the end you don't want to count at all per physical channel type, but by usage?  Then something like BSC_CTR_ASSIGNMENT_{SIGN,VOICE} might be more appropriate.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4df275e4770c5ff3643c79ba828e736986f8bb47
Gerrit-Change-Number: 22103
Gerrit-PatchSet: 4
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 08:25:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: iedemam <michael at kapsulate.com>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210112/bf0335ad/attachment.htm>


More information about the gerrit-log mailing list