This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
iedemam gerrit-no-reply at lists.osmocom.orgiedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22103 )
Change subject: stats: Add granularity to SDCCH/TCH/LU activity.
......................................................................
Patch Set 3:
(4 comments)
Thanks for the feedback. New changeset being pushed in a couple of minutes.
https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c
File src/osmo-bsc/assignment_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c@433
PS1, Line 433: case GSM_LCHAN_SDCCH:
: rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_ATTEMPTED_SDCCH]);
: break;
: case GSM_LCHAN_TCH_H:
: case GSM_LCHAN_TCH_F:
: rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_ATTEMPTED_TCH]);
: break;
> I think here conn->lchan still points to the old channel type, so you are incrementing the counters […]
Correct. Removing for now.
https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c@477
PS1, Line 477: switch (conn->lchan->type) {
: case GSM_LCHAN_SDCCH:
: rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_COMPLETED_SDCCH]);
: break;
: case GSM_LCHAN_TCH_H:
: case GSM_LCHAN_TCH_F:
: rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_COMPLETED_TCH]);
: break;
: default:
: break;
: }
> I think I would incremenet both the attempted + completed counters here. […]
I have also misunderstood this then. These counters were not yet being bunched into the reporting and are not yet necessary. Removing for now.
https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c@543
PS1, Line 543: case GSM48_CMODE_SIGN:
: rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_NO_CHANNEL_SDCCH]);
: break;
: case GSM48_CMODE_SPEECH_V1:
: case GSM48_CMODE_SPEECH_EFR:
: case GSM48_CMODE_SPEECH_AMR:
: rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_NO_CHANNEL_TCH]);
: break;
> the layer3 (04.08) channel mode does not have a 1:1 mapping to channel types. […]
It may be perfectly legal but is it common? In my admittedly limited testing of these counters it always lined up with the activity I had performed on the network. Their purpose is to detect blocking and report when an SDCCH or TCH channel has been requested but the pool was exhausted. Perhaps there is a better location to do this?
https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/osmo_bsc_filter.c
File src/osmo-bsc/osmo_bsc_filter.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/osmo_bsc_filter.c@122
PS1, Line 122: case GSM48_MT_MM_LOC_UPD_REQUEST:
: rate_ctr_inc(&conn->lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_LOCATION_UPDATE_REQUEST]);
: break;
> at least the comment on top of bsc_scan_msc_msg() hints that this function is only called in the dow […]
I added this to capture all of the ENUM elements but you're right. Removed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4df275e4770c5ff3643c79ba828e736986f8bb47
Gerrit-Change-Number: 22103
Gerrit-PatchSet: 3
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 11 Jan 2021 20:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210111/cb95cd16/attachment.htm>