This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22104 ) Change subject: tbf: add virtual destructor ...................................................................... tbf: add virtual destructor This ensures spec compliance, because currently the base class constructor would be called through a base class pointer to derived class instead of the most derived one, which ist unexpected and actually undefined behavior in c++11 and beyond. Change-Id: Ic4abde1658a983bb0ccf9a526177dce50ff6dc23 --- M src/tbf.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/04/22104/1 diff --git a/src/tbf.h b/src/tbf.h index 4bbfea2..72b5cf0 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -213,6 +213,7 @@ struct gprs_rlcmac_tbf { gprs_rlcmac_tbf(BTS *bts_, GprsMs *ms, gprs_rlcmac_tbf_direction dir); + virtual ~gprs_rlcmac_tbf() {} static void free_all(struct gprs_rlcmac_trx *trx); static void free_all(struct gprs_rlcmac_pdch *pdch); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic4abde1658a983bb0ccf9a526177dce50ff6dc23 Gerrit-Change-Number: 22104 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210111/1abbdaee/attachment.htm>