Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
......................................................................


Patch Set 2:

(8 comments)

(make sure all comments are sent)

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/include/osmocom/gprs/gprs_bssgp.h@45 
PS1, Line 45: struct bssgp_ran_information_pdu {
> shouldn't this be incorporated into struct osmo_bssgp_prim somehow?
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c 
File src/gb/gprs_bssgp_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@593 
PS1, Line 593: struct bssgp_ran_information_pdu *pdu
> const
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@621 
PS1, Line 621: LOGL_NOTICE
> DEBUG?
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@644 
PS1, Line 644: struct msgb *msg
> const
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@653 
PS1, Line 653: data_len
> I would better check if the resulting length is not negative.
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@661 
PS1, Line 661: 		pdu->routing_info_dest =
> Cosmetic: no need for line breaks here.
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@672 
PS1, Line 672: 0
> Wrong index, it should be 1!
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@704 
PS1, Line 704: 	return 0;
> Makes sense to check if the IEs are not empty.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Jan 2021 16:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210108/7faa084f/attachment.htm>