This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22051 )
Change subject: power_control: properly track the first initial state
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c
File src/common/power_control.c:
https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c@81
PS1, Line 81: if (mps->meas_num++ == 0) {
> a boolean would be better, otherwise you are applying wrong value when it overflows (not critical th […]
For other pre-processing methods (like unweighted average) it makes more sense to have a counter, so you know how many measurements you have in the buffer.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22051
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I16e7474b5affbd90855a2e407b305e9dec581dfa
Gerrit-Change-Number: 22051
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:57:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210108/6844953a/attachment.htm>