Change in osmo-gsm-tester[master]: enb_srs: only use QAM64 tables if both UE and eNB are configured for ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Jan 8 13:34:53 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038 )

Change subject: enb_srs: only use QAM64 tables if both UE and eNB are configured for QAM64
......................................................................

enb_srs: only use QAM64 tables if both UE and eNB are configured for QAM64

this was causing failed tests because to achieve QAM64 rates both
eNB and UE need to support it and have it activated.

Change-Id: I599df92d69eeb56a5d44327de08f004222cff073
---
M src/osmo_gsm_tester/obj/enb_srs.py
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/obj/enb_srs.py b/src/osmo_gsm_tester/obj/enb_srs.py
index 7fde719..1b17c3c 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -72,6 +72,7 @@
         self.remote_log_file = None
         self.remote_pcap_file = None
         self.enable_pcap = False
+        self.enable_ul_qam64 = False
         self.metrics_file = None
         self.stop_sleep_time = 6 # We require at most 5s to stop
         self.testenv = testenv
@@ -192,7 +193,9 @@
         self.enable_pcap = util.str2bool(values['enb'].get('enable_pcap', 'false'))
         config.overlay(values, dict(enb={'enable_pcap': self.enable_pcap}))
 
-        config.overlay(values, dict(enb={'enable_ul_qam64': util.str2bool(values['enb'].get('enable_ul_qam64', 'false'))}))
+        self.enable_ul_qam64 = util.str2bool(values['enb'].get('enable_ul_qam64', 'false'))
+        config.overlay(values, dict(enb={'enable_ul_qam64': self.enable_ul_qam64}))
+
         config.overlay(values, dict(enb={'enable_dl_awgn': util.str2bool(values['enb'].get('enable_dl_awgn', 'false'))}))
         config.overlay(values, dict(enb={'rf_dev_sync': values['enb'].get('rf_dev_sync', None)}))
 
@@ -287,7 +290,7 @@
                                    75: 55e6,
                                    100: 75e6}
 
-        if 'ul_qam64' in self.ue.features():
+        if self.enable_ul_qam64 and 'ul_qam64' in self.ue.features():
             max_phy_rate_tm1_ul = { 6 : 2.7e6,
                                     15 : 6.5e6,
                                     25 : 14e6,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I599df92d69eeb56a5d44327de08f004222cff073
Gerrit-Change-Number: 22038
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210108/20b5c74b/attachment.htm>


More information about the gerrit-log mailing list