Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jan 8 00:25:35 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
......................................................................


Patch Set 1: Code-Review-1

(7 comments)

CR-1 due to wrong array index.

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c 
File src/gb/gprs_bssgp_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@593 
PS1, Line 593: struct bssgp_ran_information_pdu *pdu
const


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@621 
PS1, Line 621: LOGL_NOTICE
DEBUG?


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@644 
PS1, Line 644: struct msgb *msg
const


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@653 
PS1, Line 653: data_len
I would better check if the resulting length is not negative.


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@661 
PS1, Line 661: 		pdu->routing_info_dest =
Cosmetic: no need for line breaks here.


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@672 
PS1, Line 672: 0
Wrong index, it should be 1!


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@704 
PS1, Line 704: 	return 0;
Makes sense to check if the IEs are not empty.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Jan 2021 00:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210108/120c0da4/attachment.htm>


More information about the gerrit-log mailing list