Change in osmo-gsm-tester[master]: enb: add stdout counter helper to eNB objects

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jan 7 17:21:03 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042 )

Change subject: enb: add stdout counter helper to eNB objects
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb.py 
File src/osmo_gsm_tester/obj/enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb.py@349 
PS1, Line 349:     def get_counter(self, counter_name):
I'd rather leave it as @abstractmethod here and make sure all implementations either implement it correctly or simply implement them by raising an exception like yo did here.

This way it's easier to find out when implementing a subclass what's missing before running into it (thanks to ABCMeta)


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb_srs.py 
File src/osmo_gsm_tester/obj/enb_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/enb_srs.py@89 
PS1, Line 89:         # Make sure we give time to tear down
Not related to this commit, submit in a separate commit please.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/srslte_common.py 
File src/osmo_gsm_tester/obj/srslte_common.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/1/src/osmo_gsm_tester/obj/srslte_common.py@102 
PS1, Line 102:     def _get_counter_stdout(self, keyword):
What about moving this function to Process class? as in process.count_lines(match=keyword, stream=stdout) or something alike.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8
Gerrit-Change-Number: 22042
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210107/73c35cf2/attachment.htm>


More information about the gerrit-log mailing list